fix for flaky realm info tests #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
habdelra
requested review from
jurgenwerk,
burieberry,
backspace,
lukemelia,
IanCal,
tintinthong and
FadhlanR
|
I ran CI 5 times and the host tests passed in all the runs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tracking to the realm info data such that when it changes consuming templates will update, as well as to add test waiters around the loading of the realm info. Also adding a
loadedtest-selector to the realm dropdown in case it becomes necessary.I'll re-run the CI tests a bunch of times to see if the flakiness disappears